zbchi commented on code in PR #3253:
URL: https://github.com/apache/dubbo-go/pull/3253#discussion_r2944372284
##########
server/options.go:
##########
@@ -389,14 +389,6 @@ func WithServerProtocol(opts ...protocol.ServerOption)
ServerOption {
}
}
-// todo(DMwangnima): this configuration would be used by filter/hystrix
-// think about a more ideal way to configure
-func WithServerFilterConf(conf any) ServerOption {
- return func(opts *ServerOptions) {
- opts.Provider.FilterConf = conf
- }
-}
Review Comment:
hystrix
api重构后不使用这个api，现在也没有地方把Provider.FilterConf/Consumer.FilterConf传给filter构造函数
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
