Copilot commented on code in PR #1046: URL: https://github.com/apache/dubbo-go-samples/pull/1046#discussion_r2936780008
########## generic/README_zh.md: ########## @@ -38,7 +38,7 @@ cd generic/go-client/cmd go run . ``` -客户端使用直连模式（`client.WithURL`）连接服务端，通过 `cli.NewGenericService` 进行泛化调用。同时测试 Dubbo 协议（端口 20000）和 Triple 协议（端口 50052）。 +客户端通过 ReferenceConfig 的注册中心配置从 ZooKeeper 发现服务，并使用 config/generic.GenericService 进行泛化调用。 Review Comment: 这里写“通过 ReferenceConfig 的注册中心配置从 ZooKeeper 发现服务”，但当前 Go 客户端实现是：在 RootConfig 里 `AddRegistry`，并在 ReferenceConfig 里通过 `RegistryIDs` 引用该注册中心。建议把表述改为 `RegistryIDs` / RootConfig 注册中心，以免读者按字面去找 ReferenceConfig 里的 registry 字段。 ########## generic/README.md: ########## @@ -38,7 +38,7 @@ cd generic/go-client/cmd go run . ``` -The client uses direct URL connection (`client.WithURL`) to connect to the server and performs generic calls via `cli.NewGenericService`. It tests both Dubbo protocol (port 20000) and Triple protocol (port 50052). +The client discovers providers from ZooKeeper through the registry field in ReferenceConfig and performs generic calls via config/generic.GenericService. Review Comment: The text says the Go client discovers providers “through the registry field in ReferenceConfig”, but the updated client code uses `RegistryIDs` on `ReferenceConfig` plus the registry definition on `RootConfig` (`AddRegistry`). Consider rewording to reference `RegistryIDs` / the RootConfig registry to match the implementation and avoid confusion for readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
