Similarityoung commented on PR #1429: URL: https://github.com/apache/dubbo-admin/pull/1429#issuecomment-4018761480
--- ### Code review Found 1 issue: 1. Generic invoke leaks raw upstream/internal RPC errors back to the client instead of following the console's usual stable `InternalError` pattern. The rest of `pkg/console/service` returns fixed user-facing messages and logs the cause server-side, but this new path returns `err.Error()` directly, which can expose transport/provider details and make API responses inconsistent. https://github.com/apache/dubbo-admin/blob/c04698cbee4417fe2d1b756b458c56335ca55024/pkg/console/service/service_generic_invoke.go#L148-L152 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
