Alanxtl commented on code in PR #3235:
URL: https://github.com/apache/dubbo-go/pull/3235#discussion_r2901558551
##########
config/graceful_shutdown.go:
##########
@@ -99,14 +98,8 @@ func gracefulShutdownInit() {
// BeforeShutdown provides processing flow before shutdown
func BeforeShutdown() {
destroyAllRegistries()
- // waiting for a short time so that the clients have enough time to get
the notification that server shutdowns
- // The value of configuration depends on how long the clients will get
notification.
waitAndAcceptNewRequests()
-
- // reject sending/receiving the new request, but keeping waiting for
accepting requests
waitForSendingAndReceivingRequests()
-
- // destroy all protocols
Review Comment:
do not delete these comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
