AlexStocks commented on code in PR #3195:
URL: https://github.com/apache/dubbo-go/pull/3195#discussion_r2899092456
##########
config/logger_config.go:
##########
@@ -112,6 +124,17 @@ func (l *LoggerConfig) toURL() *common.URL {
common.WithParamsValue(constant.LoggerFileMaxAgeKey,
strconv.Itoa(l.File.MaxAge)),
common.WithParamsValue(constant.LoggerFileCompressKey,
strconv.FormatBool(*l.File.Compress)),
)
+
+ // Add trace integration parameters if configured
+ if l.TraceIntegration != nil {
+ if l.TraceIntegration.Enabled != nil {
+ url.AddParam(constant.LoggerTraceEnabledKey,
strconv.FormatBool(*l.TraceIntegration.Enabled))
Review Comment:
原有参数统一在 `NewURL` 时通过 `common.WithParamsValue` 传入，新增的 trace 参数改用
`url.AddParam()` 追加，风格不统一。
建议：改用 `common.WithParamsValue` 在 `NewURL` 调用中统一传入 trace 参数。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
