chewbranca commented on PR #5602:
URL: https://github.com/apache/couchdb/pull/5602#issuecomment-3105477204
Over in 38a53a059 I migrated CSRT into the `couch_srt` application, aka CSRT
for short. For context, I did so with a series of sed commands and a bit of
manual cleanup. I did that incrementally and did local git commits with the
different steps and sed commands as commit messages where used, which I then
squashed down into a final commit before pushing out here, but here's the
squashed sequence of steps to generate the above git sha:
```
Extract CSRT into dedicated couch_srt application
sed -I '' 's/csrt.hrl/couch_srt.hrl/g' src/*/{src,test/eunit}/*.erl
sed -I '' 's/csrt:/couch_srt:/g' src/*/{src,test/eunit}/*.erl
sed -I '' 's/csrt_\([a-z_]*\):/couch_srt_\1:/g' src/*/{src,test/eunit}/*.erl
Cleanup remaining 'csrt\(_[a-z_]*\)\?:' references
Hook in couch_srt app
sed -I '' 's/^-module(csrt/-module(couch_srt/g' src/*/{src,test/eunit}/*.erl
More cleanup
```
That commit creates a clean separation between `couch_stats` and
`couch_srt`, and I even moved most of the `couch_stats` changes to within
`couch_srt`.
One thing that I'd like feedback on in particular, I preserved the name
"CSRT" as I think it's a good name for the system and I've grown accustomed to
referring to it as such. The public Erlang APIs all use `couch_srt`, but
internally within I've kept the use of `csrt` in a number of places. I still
think CSRT is a better and more concise name than `couch_srt`, so I've left
that in the documentation and config settings as I think the conciseness of
"csrt" helps in a number of places, for instance, I'm still using `"csrt"` and
`"csrt_logger.matchers_threshold"` for the config settings as I think that's
cleaner and more user friendly that `couch_srt_logger.matchers_threshold`.
I like the balance of `"couch_srt"` and `"csrt"` in that commit so I didn't
go further on renaming things in `couch_srt.hrl`, but let me know what y'all
think.
I kept that as an isolated commit to have a logical commit containing all
the direct sed changes, and then I waited to run `make erlfmt-format` until
afterwards so folks could reasonably follow the sed commit and not be surprised
by the format updates in 86ba96be0.
Tomorrow I'll add some additional updates to the overview documentation to
better illustrate when/where/how users would initially enable and utilize CSRT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
