big-r81 commented on code in PR #72:
URL: https://github.com/apache/couchdb-ci/pull/72#discussion_r1740899796


##########
bin/apt-dependencies.sh:
##########
@@ -118,8 +118,8 @@ EOF
 fi
 
 # rest of python dependencies
-if [ "${VERSION_CODENAME}" == "bookworm" ]; then
-    # On Debian bookworm, need the --break-system-package to into to default 
system location
+if [ "${VERSION_CODENAME}" == "bookworm" -o "${VERSION_CODENAME}" == "noble" 
]; then
+    # On Debian bookworm and Ubuntu noble, need the --break-system-package to 
into to default system location
     pip3 --default-timeout=10000 install --break-system-packages --upgrade 
sphinx_rtd_theme nose requests hypothesis==3.79.0
 else
     pip3 --default-timeout=10000 install --upgrade sphinx_rtd_theme nose 
requests hypothesis==3.79.0

Review Comment:
   s.a.



##########
bin/apt-dependencies.sh:
##########
@@ -118,8 +118,8 @@ EOF
 fi
 
 # rest of python dependencies
-if [ "${VERSION_CODENAME}" == "bookworm" ]; then
-    # On Debian bookworm, need the --break-system-package to into to default 
system location
+if [ "${VERSION_CODENAME}" == "bookworm" -o "${VERSION_CODENAME}" == "noble" 
]; then
+    # On Debian bookworm and Ubuntu noble, need the --break-system-package to 
into to default system location
     pip3 --default-timeout=10000 install --break-system-packages --upgrade 
sphinx_rtd_theme nose requests hypothesis==3.79.0

Review Comment:
   @nickva Do we really need this anymore (also applies to the other CI 
images). I think we have our own venv in the docs folder for this, when 
building the docs ...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to