nickva commented on code in PR #5204:
URL: https://github.com/apache/couchdb/pull/5204#discussion_r1731756688
##########
src/fabric/src/fabric_view_changes.erl:
##########
@@ -98,13 +98,15 @@ keep_sending_changes(DbName, Args, Callback, Seqs, AccIn,
Timeout, UpListen, T0)
LastSeq = pack_seqs(NewSeqs),
MaintenanceMode = config:get("couchdb", "maintenance_mode"),
NewEpoch = get_changes_epoch() > erlang:get(changes_epoch),
+ PendingCount = pending_count(Offset),
if
+ Dir == rev, is_integer(PendingCount), PendingCount =< 0;
Review Comment:
Minor update: I asserted that PendingCount is an integer. If we haven't
heard from at least on worker it will be `null`. That would have also worked
as `null` sorts greater than `0` but it's better to be explicit probably.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
