chewbranca commented on issue #5127: URL: https://github.com/apache/couchdb/issues/5127#issuecomment-2231472387
Looks like `dreyfus_rpc` does the right thing and cleanup the `Workers` in the outer after clause https://github.com/apache/couchdb/blob/main/src/dreyfus/src/dreyfus_fabric_search.erl#L147 and it looks like that's the full list of workers too, not just the winning shard range workers. I suggest, at a minimum, we follow the same pattern from `dreyfus_rpc` and do cleanup on the full set of workers in the after clause. I say "at a minimum" because I think we should consider moving the cleanup to the dedicated `rexi_mon` process such that if the coordinator process dies it'll still have the workers cleaned up. This is definitely a secondary concern compared to the main source of stranded workers in this ticket, but still worth considering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
