nickva opened a new pull request, #5126:
URL: https://github.com/apache/couchdb/pull/5126
Hyper is powering our `_approx_count_distinct` reducer. The dependency isn't
updated much and there is an under-counting bug discussed in issue #5084.
There is a more active fork [1], but moving to it is not practical as the
context records are changed. Unfortunately for us, those are part of the
on-disk indexing data structures. If we change them we risk breaking users'
views.
Additionally, we're not using most of the hyper library functionality: we
only use one backend, one precision value (11), and only a few API functions.
In light of that it makes sense to simplify the library and remove all the
un-used stuff. Also, add 100% test coverage, and fix the bug found by the
LivewareProblems/hyper fork.
In order to ensure we don't inadvertently modify the on-disk records those
are marked with a comment, and there is unit test that would break if we change
them. The existing record structure is kept as-is for that exact reason
including the silly mention of the `{hyper_binary, ...}` atom in the registers
field, just to ensure there are no compatibility issues for our users' views.
Fix #5084
[1] LivewareProblems/hyper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
