nickva commented on code in PR #5013: URL: https://github.com/apache/couchdb/pull/5013#discussion_r1536690522
########## src/mem3/src/mem3.erl: ########## @@ -423,31 +424,127 @@ engine(Opts) when is_list(Opts) -> %% Check whether a node is up or down %% side effect: set up a connection to Node if there not yet is one. --spec ping(Node :: atom()) -> pong | pang. +-spec ping(Node :: atom()) -> pos_integer() | Error :: term(). Review Comment: I couldn't find any usage or in the API or docs about it so figured `pang` is less useful than an explanation why it failed, and `pong` is less useful than an actual time it took to respond. Then it would also be somewhat compatible with ping_nodes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
