pgj commented on code in PR #4627:
URL: https://github.com/apache/couchdb/pull/4627#discussion_r1521395723


##########
configure:
##########
@@ -298,7 +318,7 @@ if [ "${ARCH}" = "aarch64" ] && [ "${SM_VSN}" = "60" ]; then
   exit 1
 fi
 
-if [ "${ERLANG_OS}" = "unix" ]; then
+if [ "${JS_ENGINE}" = "spidermonkey" ] && [ "${ERLANG_OS}" = "unix" ]; then

Review Comment:
   This check should not be skipped unless support for SpiderMonkey is 
completely disabled.  That is, this part has to be modified in lockstep with 
the part that is responsible for building SM.  If that is not deactivated, this 
should not be either.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to