madrob commented on code in PR #55:
URL: https://github.com/apache/comdev/pull/55#discussion_r4321033383
##########
mcp/ponymail-mcp/index.js:
##########
@@ -43,6 +43,18 @@ import {
} from "./restrictions.js";
import { Mail, extractListDomain, countDescendants } from "./mail.js";
+// Node's built-in fetch only uses proxy variables when NODE_USE_ENV_PROXY=1
+// is set at startup, so a proxy variable alone would be silently ignored.
+if (
+ ["HTTPS_PROXY", "https_proxy", "HTTP_PROXY", "http_proxy"].some((v) =>
process.env[v]) &&
+ !process.env.NODE_USE_ENV_PROXY
+) {
Review Comment:
94252b2
##########
mcp/apache-projects-mcp/index.js:
##########
@@ -746,6 +746,18 @@ server.tool(
// ---------------------------------------------------------------------------
if (process.argv[1] && import.meta.url ===
pathToFileURL(process.argv[1]).href) {
+ // Node's built-in fetch only uses proxy variables when NODE_USE_ENV_PROXY=1
+ // is set at startup, so a proxy variable alone would be silently ignored.
+ if (
+ ["HTTPS_PROXY", "https_proxy", "HTTP_PROXY", "http_proxy"].some((v) =>
process.env[v]) &&
+ !process.env.NODE_USE_ENV_PROXY
+ ) {
Review Comment:
94252b2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
