>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb.
Michael Blow has posted comments on this change by Hussain Towaileb. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485?usp=email ) Change subject: [ASTERIXDB-3657][FAIL]: handle non-serialize exceptions ...................................................................... Patch Set 2: (2 comments) File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/JavaSerializationUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485/comment/0a882145_263942a9?usp=email : PS2, Line 40: public static final Set<Class<? extends Throwable>> toProxy = new HashSet<>(); this is not safe to have as a public set, it should probably also be thread safe, as I'm not sure we can guarantee no parallel access when using in-process integration utils. e.g. `ConcurrentHashMap` https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485/comment/94579967_7f9b32c6?usp=email : PS2, Line 163: if (obj instanceof Throwable throwable && toProxy.contains(throwable.getClass())) { no need for `obj instanceof Throwable throwable` here, can just use `toProxy.contains(obj.getClass())` I feel like we should make this more general purpose, and change toProxy to be a <Class,<Function<Object,Object>> map of replacements... in this case, you can probably still keep `SerializableExceptionProxy`, only make it public, and then it can be registered like ```JavaSerializationUtils.registerReplacement(BlobStorageException.class, SerializableExceptionProxy::new)``` -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20485?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: I55e69623068a6c1759803cc699417021910237fd Gerrit-Change-Number: 20485 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 02:59:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
