>From Ian Maxon <[email protected]>: Attention is currently required from: Michael Blow.
Ian Maxon has posted comments on this change by Ian Maxon. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email ) Change subject: [ASTERIXDB-3640][TEST]Use s3mock in testcontainers ...................................................................... Patch Set 17: (4 comments) Patchset: PS3: > We should move this to Phoenix Done File asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/LocalCloudUtilAdobeMock.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/2d5b470f_748a8d71?usp=email : PS15, Line 93: URI endpoint = URI.create(s3Mock.getHttpEndpoint()); // endpoint pointing to S3 mock server > thank you for this- it grinds my gears when we force containers to map to > specific ports on the host […] no worries, indeed any static mapping is bad. there's no way to use testcontainers that way, which fortunately enforces discipline. i should make the IP not static as well, but i started to run into the path/subdomain addressing issues with s3mock. File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/array_fun/array_slice/array_slice_bracket_notation/array_slice_bracket_notation.099.ddl.sqlpp: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/fdf19541_983eb18d?usp=email : PS15, Line 1: /* > we probably don't need the 'x' bit right? yeah i have no idea why all the tests in this folder are +x File asterixdb/pom.xml: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280/comment/561d43f4_3f43dc3c?usp=email : PS15, Line 1580: <artifactId>s3mock</artifactId> > we probably need to move this to cbas/pom.xml in a coordinated change for > that project. yeah i wish i realized that earlier, added a topic -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20280?usp=email To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: asterixdb Gerrit-Branch: phoenix Gerrit-Change-Id: Iad1a6f9331fd844f3e3c04b8f56e811e4117f83a Gerrit-Change-Number: 20280 Gerrit-PatchSet: 17 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Comment-Date: Thu, 25 Sep 2025 20:16:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Blow <[email protected]>
