>From Peeyush Gupta <[email protected]>:

Attention is currently required from: Ian Maxon, Murtadha Hubail.

Peeyush Gupta has posted comments on this change by Ian Maxon. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20292?usp=email )

Change subject: [ASTERIXDB-3644] Callback for result consumption
......................................................................


Patch Set 5:

(1 comment)

File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20292/comment/dd8a7cd1_4c4d3c64?usp=email
 :
PS5, Line 124:             response.setStatus(HttpResponseStatus.BAD_REQUEST);
             :             response.writer().println(e.getMessage());
We should keep it right? Ideally on an exception we should return error codes 
and corresponding messages like we do for the sync api. I am any ways working 
on it as part of the async api changes.



--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20292?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: I768eab7bd3ed1dbfda1bd3449264c92952b4cb53
Gerrit-Change-Number: 20292
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Maxon <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Peeyush Gupta <[email protected]>
Gerrit-Attention: Murtadha Hubail <[email protected]>
Gerrit-Attention: Ian Maxon <[email protected]>
Gerrit-Comment-Date: Tue, 09 Sep 2025 20:02:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No

Reply via email to