>From Michael Blow <[email protected]>: Attention is currently required from: Hussain Towaileb. Michael Blow has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20296 )
Change subject: [ASTERIXDB-3643][EXT]: Make path-access-style configurable ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: This needs to be moved to Phoenix. File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3AuthUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20296/comment/2b6ff254_52a6b53c PS2, Line 404: HADOOP_PATH_STYLE_ACCESS I see where you got access from, but I still would prefer our interfaces be consistent with each other. (see comment in S3Constants.java) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/aws/s3/S3Constants.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20296/comment/27866194_62fa275a PS2, Line 28: pathStyleAccess We in our EA settings use the property blobStoragePathStyleAddressing for this, (based on ChatGPT referring to this as "path-style addressing"). Can we use that nomenclature here? This doesn't really have to do with "access" which refers to authorization in S3. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20296 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I068f9caa9d9ea800d62954a1863b91d2074c29c6 Gerrit-Change-Number: 20296 Gerrit-PatchSet: 2 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 05 Sep 2025 14:31:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
