>From Preetham Poluparthi <[email protected]>:
Attention is currently required from: Ali Alsuliman, Preetham Poluparthi.
Hello Ali Alsuliman, Jenkins, Anon. E. Moose #1000171,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20282
to look at the new patch set (#4).
Change subject: [ASTERIXDB-3632] Fix NPEs in Index Advisor and add error
handling for missing samples
......................................................................
[ASTERIXDB-3632] Fix NPEs in Index Advisor and add error handling for missing
samples
- user model changes: no
- storage format changes: no
- interface changes: no
Ext-ref: MB-66492
Details:
This patch addresses several corner cases in the Index Advisor:
- Fixes null pointer exceptions that occur in scenarios such as:
- Collections with secondary primary indexes
- Cases where CBO bails out
- Adds proper error handling when an `ADVISE` query is issued without CBO
enabled
- Introduces error reporting for collections that have no samples, suggesting
the use of ANALYSE SAMPLE before issuing advise
Change-Id: I346728dd634934416d7115a06ab15572b5a98854
---
M
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/base/IndexAdvisor.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/FakeIndexProvider.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/AdvisorConditionParser.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
M
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/EnumerateJoinsRule.java
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/cbo/indexadvisor/AdviseIndexRule.java
10 files changed, 140 insertions(+), 42 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/82/20282/4
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20282
To unsubscribe, or for help writing mail filters, visit
https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I346728dd634934416d7115a06ab15572b5a98854
Gerrit-Change-Number: 20282
Gerrit-PatchSet: 4
Gerrit-Owner: Preetham Poluparthi <[email protected]>
Gerrit-Reviewer: Ali Alsuliman <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Preetham Poluparthi <[email protected]>
Gerrit-Attention: Ali Alsuliman <[email protected]>
Gerrit-Attention: Preetham Poluparthi <[email protected]>
Gerrit-MessageType: newpatchset
