>From Murtadha Hubail <[email protected]>: Attention is currently required from: Michael Blow, Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283 )
Change subject: [ASTERIXDB-3636][STO] Fix buffer reservations understimation ...................................................................... Patch Set 7: (8 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/33e403b4_837ac8a3 PS7, Line 11: no yes File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/bytes/encoder/AbstractParquetDeltaBinaryPackingValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/c1bd8b27_2a261606 PS7, Line 41: // 1 for temporary buffers so true File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/operation/lsm/flush/NoWriteFlushColumnMetadata.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/0e8f1446_4e447ce2 PS7, Line 69: bufferRequiredByCurrentTuple buffersRequiredByCurrentTuple https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/48d01db1_50b0c74d PS7, Line 210: getBufferRequiredByWriter getBuffersRequiredByWriter File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/IColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/8fed0ac2_a57a6a67 PS7, Line 141: requiredTemporaryBuffersCount getRequiredTemporaryBuffersCount File asterixdb/asterix-column/src/main/java/org/apache/asterix/column/values/writer/BooleanColumnValuesWriter.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/92f5d061_d6e3a81f PS7, Line 95: 0 if you indeed need both methods, at least call the static from this one if they are identical File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/StorageProperties.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/58d28ca7_dc675603 PS6, Line 83: return 5.0d; > Should we set this to 0. […] Let's go with 50% for small JVMs in the hopes that no current queries are running while ingestion is happening on those small JVMs. File hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/ColumnBufferPool.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283/comment/9a3fc6ec_bb1d94c5 PS7, Line 46: buffersAllocated do you really need this or can you reuse some existing variable to do this check? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20283 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: ionic Gerrit-Change-Id: I3bfb9e9ac4b908ee2e7d84cab4781f6e0f7444e8 Gerrit-Change-Number: 20283 Gerrit-PatchSet: 7 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Mon, 01 Sep 2025 11:38:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ritik Raj <[email protected]> Gerrit-MessageType: comment
