>From Ian Maxon <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta, Ali Alsuliman, Michael Blow, Hussain Towaileb. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20272 )
Change subject: [ASTERIXDB-3634][EXT]: Add support to Iceberg ...................................................................... Patch Set 3: (4 comments) File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/handlers/CatalogStatementHandler.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20272/comment/16758596_8cfa66fc PS3, Line 226: // TODO(htowaileb): what is transaction state? pretty sure it's a remnant from external indexing v.1 https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20272/comment/b7a5b1f5_536af925 PS3, Line 281: MetadataTransactionContext mdTxnCtx, MetadataProvider metadataProvider unused? File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/IcebergCatalogDetails.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20272/comment/59cc5fc4_bb7bf7ea PS3, Line 151: @Override : public String toString() { : ObjectMapper mapper = new ObjectMapper(); : try { : return mapper.writeValueAsString(toMap()); : } catch (JsonProcessingException e) { : LOGGER.log(Level.WARN, "Unable to convert map to json String", e); : return getClass().getSimpleName(); : } : } : : private Map<String, Object> toMap() { : Map<String, Object> map = new HashMap<>(); : map.put("adapter", adapter); : map.put("properties", properties); : map.put("lastRefreshTime", lastRefreshTime.toString()); : map.put("state", state.name()); : return map; : } when does this get used instead of the other serialization form? File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/MetadataLockUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20272/comment/6a75392d_59b451e4 PS3, Line 402: createCatalogBeing nit: typo? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20272 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: If825dfc3241f72fcece03874662fc2dc8f553920 Gerrit-Change-Number: 20272 Gerrit-PatchSet: 3 Gerrit-Owner: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-CC: Michael Blow <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Michael Blow <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Comment-Date: Fri, 29 Aug 2025 06:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
