>From Murtadha Hubail <[email protected]>:

Murtadha Hubail has submitted this change. ( 
https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20273 )

Change subject: [NO ISSUE][STO] Delete masked files before reading resource 
files
......................................................................

[NO ISSUE][STO] Delete masked files before reading resource files

- user model changes: no
- storage format changes: no
- interface changes: no

Details:

- During local storage clean up, delete masked (incomplete) files before
  trying to access any resource files to avoid reading corrupted data.

Ext-ref: MB-68162
Change-Id: I58efaab43421dcb88d3341fd6cd7428104a8c70e
Reviewed-on: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20273
Integration-Tests: Murtadha Hubail <[email protected]>
Tested-by: Murtadha Hubail <[email protected]>
Reviewed-by: Murtadha Hubail <[email protected]>
Reviewed-by: Michael Blow <[email protected]>
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/LocalStorageCleanupTask.java
1 file changed, 25 insertions(+), 1 deletion(-)

Approvals:
  Murtadha Hubail: Looks good to me, but someone else must approve; Verified; 
Verified
  Michael Blow: Looks good to me, approved
  Anon. E. Moose #1000171:




diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/LocalStorageCleanupTask.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/LocalStorageCleanupTask.java
index 435419b..61a07d1 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/LocalStorageCleanupTask.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/task/LocalStorageCleanupTask.java
@@ -43,9 +43,9 @@
         INcApplicationContext appContext = (INcApplicationContext) 
cs.getApplicationContext();
         PersistentLocalResourceRepository localResourceRepository =
                 (PersistentLocalResourceRepository) 
appContext.getLocalResourceRepository();
+        localResourceRepository.deleteCorruptedResources();
         deleteInvalidMetadataIndexes(localResourceRepository);
         final Set<Integer> nodePartitions = 
appContext.getReplicaManager().getPartitions();
-        localResourceRepository.deleteCorruptedResources();
         INcApplicationContext appCtx = (INcApplicationContext) 
cs.getApplicationContext();
         if (appCtx.isCloudDeployment() && 
nodePartitions.contains(metadataPartitionId)) {
             
appCtx.getTransactionSubsystem().getTransactionManager().rollbackMetadataTransactionsWithoutWAL();

--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20273
To unsubscribe, or for help writing mail filters, visit 
https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: ionic
Gerrit-Change-Id: I58efaab43421dcb88d3341fd6cd7428104a8c70e
Gerrit-Change-Number: 20273
Gerrit-PatchSet: 5
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-MessageType: merged

Reply via email to