DSingh0304 commented on PR #3277:
URL:
https://github.com/apache/apisix-dashboard/pull/3277#issuecomment-4112966557
> Thanks for the fix. The root cause analysis and fix direction (disabling
`emptyObjectsCleaner` + targeted cleanup for upstream empty shell fields) are
correct.
>
> However, there's one blocking item to address:
>
> The reproduction in #3269 covers both **add** and **edit** paths ("add or
edit route"). The current e2e only covers the "edit existing config to `{}`"
path but misses the "create with empty plugin config `{}`" path. These two
paths are not fully equivalent in the frontend serialization pipeline, so the
missing test case leaves a regression blind spot.
>
> Please add a minimal e2e test:
>
> * Create a Route with `key-auth` set to `{}`
>
> * After saving, verify in the detail page that `plugins["key-auth"]`
still exists with value `{}`
>
>
> Once this is covered and CI passes, we can re-review.
@Baoyuantop I have added the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
