twellck commented on issue #13112: URL: https://github.com/apache/apisix/issues/13112#issuecomment-4108391537
Happy on the breakdown, functional fix first with template-only changes, refactor as a follow-up. Good catch on the `[::1]` vs `[::]` distinction for loopback-bound listeners, I'll make sure that's handled correctly. On proxy_protocol scope, the main idea behind the reference implementation was to bring feature parity with `node_listen` and `ssl.listen`, primarily multi-IP binding (e.g. binding to specific interfaces for separate internal/external NLBs). Aligning the config format with `node_listen` would naturally include multi-port as well, since restricting it would mean a different schema for the same pattern. Happy to move this to a separate issue or just in separate an additional PR referencing this issue, let me know what you would prefer. Happy to start with a PR for the template-only IPv6 fix across all endpoints and once that's done move onto refactoring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
