DSingh0304 commented on PR #3222: URL: https://github.com/apache/apisix-dashboard/pull/3222#issuecomment-4107700822
> The direction is right — hybrid filtering is a reasonable transitional approach given API limitations. However, there are several blocking items: > > 1. **Data completeness**: Client-side filtering only operates on the first `PAGE_SIZE_MAX` items. For larger datasets, this will produce false negatives (missing matches). > > 2. **Status value coupling**: `STATUS_ALL='Disabled/Enabled'` is coupled with string comparisons in filter logic. Please refactor to internal enum values + i18n label mapping. > > 3. **Parameter compatibility**: After adding new fields to `pageSearchSchema`, the migration path for old URL parameters is unclear. Please add compatibility mapping or a documented migration strategy. > > 4. **Scope control**: The large `routeTree.gen.ts` changes have low relevance to the search feature. > > Sure, I will go through the comments and address them all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
