DSingh0304 commented on PR #3295: URL: https://github.com/apache/apisix-dashboard/pull/3295#issuecomment-4089163735
> Good root cause analysis — the `shouldUnregister: true` + missing `defaultValues` interaction is a classic react-hook-form pitfall and the fix direction is correct. > > However there are a few issues that need to be addressed before this can be merged. See inline comments below. > > **Summary:** > Category Items > Must fix Missing Suspense boundaries (services, upstreams), e2e `deleteAllUpstreams` still present > Suggestion Suspense fallback style inconsistency, consider `useMemo` for `formDefaults` Sure, I will go through the comments and apply the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
