janiussyafiq commented on code in PR #13091:
URL: https://github.com/apache/apisix/pull/13091#discussion_r2957198521
##########
t/cli/test_admin.sh:
##########
@@ -32,6 +32,10 @@ deployment:
admin_api_mtls:
admin_ssl_cert: '../t/certs/apisix_admin_ssl.crt'
admin_ssl_cert_key: '../t/certs/apisix_admin_ssl.key'
+ admin_key:
+ - name: admin
+ key: ''
+ role: admin
Review Comment:
<img width="747" height="516" alt="image"
src="https://github.com/user-attachments/assets/63cf574e-fefd-45ea-8bd7-bf7bd94ceacc";
/>
This is what causes it, which is the main root cause for this issue since it
rewrites the whole config file with the in-mem config, when the `changed =
true` where we auto-generate the password. is this intended? i removed it (same
as the previous PR approach) to avoid config file getting rewritten, causing it
to break lots of test cases. this is the tradeoff that needs to be considered
since the expected behavior requires that the config file should not be
rewritten in any way. however, things to note is that the first-time user would
still be able to run apisix without configuring anything on config file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
