Baoyuantop commented on PR #3331:
URL:
https://github.com/apache/apisix-dashboard/pull/3331#issuecomment-4072100086
Thanks for the contribution!
This PR is doing too many things at once (57 files, 5+ independent
concerns), which makes it hard to review safely. I'd suggest splitting it:
1. **`ResourceListPage` abstraction** — new component + route file
refactoring
2. **E2E test isolation** — `uniquePrefix`, targeted cleanup, Monaco helpers
3. **`useTablePagination` fix** — explain what bug this addresses
4. **Other fixes** — `@iconify/utils` downgrade, `pageSearch.ts` change,
etc. (each needs justification)
A few things to address regardless:
- `fullyParallel: !process.env.CI` disables CI parallelism — fix root causes
instead
- Empty `catch {}` blocks (3 places) silently swallow errors
- Hardcoded `timeout: 30000` everywhere — use `playwright.config.ts`
`expect.timeout`
- `page.waitForTimeout(500)` is a known flakiness anti-pattern
Please split into focused PRs so we can review and merge incrementally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
