Copilot commented on code in PR #3325:
URL: https://github.com/apache/apisix-dashboard/pull/3325#discussion_r2942101758
##########
src/locales/es/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secreto"
},
"services": {
- "singular": "Servicio"
+ "singular": "Servicio",
+ "empty": "No se encontraron servicios. Haga clic en Añadir Servicio para
crear el primero."
Review Comment:
This string hard-codes the action label (“Añadir Servicio”), but the UI
constructs that label via `info.add.title` + `services.singular`. That means
any future change to the add-action translation will require updating this
message too. Prefer wording that doesn’t reference the exact button text, or
change the UI to interpolate the computed label into `services.empty`.
##########
src/locales/tr/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "Service"
+ "singular": "Service",
+ "empty": "Service bulunamadı. İlk Service'inizi oluşturmak için Service
Ekle'ye tıklayın."
Review Comment:
The empty-state message includes the literal action label (“Service Ekle”),
but the UI generates that label from `info.add.title` + `services.singular`.
This duplicates translation concerns and may become inconsistent if the button
text changes. Consider avoiding the explicit button label in this message, or
have the UI interpolate the computed label into `services.empty`.
##########
src/locales/de/common.json:
##########
@@ -329,7 +329,8 @@
"singular": "Secret"
},
"services": {
- "singular": "Service"
+ "singular": "Service",
+ "empty": "Keine Services gefunden. Klicken Sie auf Service hinzufügen, um
Ihren ersten zu erstellen."
Review Comment:
The translated empty-state text hard-codes the current button label
(“Service hinzufügen”). Since the actual button label is produced via i18n
(`t('info.add.title', { name: t('services.singular') })`), this couples two
separate translations and will drift if the action text changes. Consider
rewording to avoid naming the button, or update the UI to pass the computed
label as an interpolation variable for `services.empty`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
