moonming commented on PR #12784: URL: https://github.com/apache/apisix/pull/12784#issuecomment-4064882157
Hi @caiqi1111, thank you for looking into this! I appreciate the effort, but I have a few concerns with the current state: 1. **Missing test coverage**: There are no test cases to verify the `data_stream` behavior, which makes it hard to validate the change. 2. **Incomplete approach**: Proper `data_stream` support in Elasticsearch logger should be implemented through a schema-level `data_stream` configuration field (similar to how the `index` field works), rather than just changing the `op_type`. The data stream API has different semantics around indexing. 3. **Inactivity**: This PR has been inactive for several months without addressing the feedback. I'm going to close this PR for now. If you're still interested in adding proper data stream support, I'd suggest: - Adding a `data_stream` boolean or object field to the plugin schema - Adjusting the bulk API call format accordingly - Including comprehensive test cases Feel free to open a new PR with the more complete implementation. Thanks again for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
