Copilot commented on code in PR #3317:
URL: https://github.com/apache/apisix-dashboard/pull/3317#discussion_r2931632646
##########
e2e/tests/services.routes.crud.spec.ts:
##########
@@ -205,7 +205,8 @@ test('should CRUD route under service with required
fields', async ({
// We're already on the detail page from the previous step
// Delete the route
- await page.getByRole('button', { name: 'Delete' }).click();
+ // eslint-disable-next-line playwright/no-force-option
+ await page.getByRole('button', { name: 'Delete', exact: true }).click({
force: true });
Review Comment:
Forcing clicks bypasses Playwright’s actionability checks and can hide real
UI issues (or create intermittent clicks on covered/disabled elements). A more
stable approach is to explicitly wait for the button to be visible and enabled
(or for overlays/spinners to disappear) before clicking, so the lint
suppression isn’t needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
