Revolyssup opened a new pull request, #12607: URL: https://github.com/apache/apisix/pull/12607
- In case of service discovery, the node_ver information is not attached to the service received from etcd (due to deepcopy) therefore it's lost and healthchecker is not recreated. - In case of dns, dns_value is not attached to the data from etcd for similar reason. Solution: - Since we use the data from etcd in healthcheck, we need the runtime information like nodes_ver and dns_value to be stored. This PR refactors the code so that those runtime updated values are persisted for future requests via healthcheck module. ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) <!-- Note 1. Mark the PR as draft until it's ready to be reviewed. 2. Always add/update tests for any changes unless you have a good reason. 3. Always update the documentation to reflect the changes made in the PR. 4. Make a new commit to resolve conversations instead of `push -f`. 5. To resolve merge conflicts, merge master instead of rebasing. 6. Use "request review" to notify the reviewer after making changes. 7. Only a reviewer can mark a conversation as resolved. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
