kayx23 commented on code in PR #12571:
URL: https://github.com/apache/apisix/pull/12571#discussion_r2315224892
##########
docs/en/latest/plugins/ai-proxy-multi.md:
##########
@@ -51,7 +51,7 @@ In addition, the Plugin also supports logging LLM request
information in the acc
| Name | Type | Required | Default
| Valid Values | Description |
|------------------------------------|----------------|----------|-----------------------------------|--------------|-------------|
-| fallback_strategy | string | False |
instance_health_and_rate_limiting | instance_health_and_rate_limiting |
Fallback strategy. When set, the Plugin will check whether the specified
instance’s token has been exhausted when a request is forwarded. If so, forward
the request to the next instance regardless of the instance priority. When not
set, the Plugin will not forward the request to low priority instances when
token of the high priority instance is exhausted. |
+| fallback_strategy | string or array | False | |
"instance_health_and_rate_limiting" "http_429", "http_5xx" or ["rate_limiting",
"http_429", "http_5xx"] | Fallback strategy. When set, the Plugin will check
whether the specified instance’s token has been exhausted when a request is
forwarded. If so, forward the request to the next instance regardless of the
instance priority. When not set, the Plugin will not forward the request to low
priority instances when token of the high priority instance is exhausted. |
Review Comment:
The valid value format is slightly confusing, since this doc uses `[ ]` to
list all the configurable values for strings as well. How about:
```suggestion
| fallback_strategy | string or array | False |
| string: "instance_health_and_rate_limiting", "http_429", "http_5xx"<br>array:
["rate_limiting", "http_429", "http_5xx"] | Fallback strategy. When set, the
Plugin will check whether the specified instance’s token has been exhausted
when a request is forwarded. If so, forward the request to the next instance
regardless of the instance priority. When not set, the Plugin will not forward
the request to low priority instances when token of the high priority instance
is exhausted. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
