SkyeYoung commented on code in PR #12551:
URL: https://github.com/apache/apisix/pull/12551#discussion_r2315155954


##########
t/core/trusted-addresses.t:
##########
@@ -0,0 +1,219 @@
+#

Review Comment:
   Other than chaitin-waf, [the original 
PR](https://github.com/apache/apisix/pull/12029) didn't find any tests covering 
the `real_client_ip=true` scenario, and after spending time researching, I also 
couldn't find the actual purpose of this parameter.



##########
t/core/trusted-addresses.t:
##########
@@ -0,0 +1,219 @@
+#

Review Comment:
   Other than `chaitin-waf`, [the original 
PR](https://github.com/apache/apisix/pull/12029) didn't find any tests covering 
the `real_client_ip=true` scenario, and after spending time researching, I also 
couldn't find the actual purpose of this parameter.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to