bzp2010 commented on code in PR #2507:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2507#discussion_r2281412325
##########
api/adc/types.go:
##########
Review Comment:
The `api` folder seems to be used to store CRDs. Would it be appropriate to
place an ADC type here?
##########
.github/workflows/apisix-conformance-test.yml:
##########
@@ -89,7 +89,7 @@ jobs:
- name: Install And Run Cloud Provider KIND
run: |
- go install sigs.k8s.io/cloud-provider-kind@latest
+ go install sigs.k8s.io/[email protected]
Review Comment:
The latest version is `0.7.0`, why can't we use `latest`?
##########
internal/provider/common/configmanager.go:
##########
@@ -0,0 +1,146 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package common
+
+import (
+ "sync"
+)
+
+type ConfigManager[K comparable, T any] struct {
Review Comment:
Please add some comments to point out the purpose of this structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
