SkyeYoung commented on code in PR #12516: URL: https://github.com/apache/apisix/pull/12516#discussion_r2271924232
########## docs/en/latest/discovery/kubernetes.md: ########## @@ -318,7 +318,10 @@ metadata: name: apisix-test rules: - apiGroups: [ "" ] - resources: [ endpoints,endpointslices ] + resources: [ endpoints ] + verbs: [ get,list,watch ] +- apiGroups: [ "discovery.k8s.io" ] + resources: [ endpointslices ] Review Comment: Based on the documentation, this feature only reached stable status in Kubernetes `v1.21`. Did the original documentation work correctly in older versions? ########## docs/en/latest/discovery/kubernetes.md: ########## @@ -318,7 +318,10 @@ metadata: name: apisix-test rules: - apiGroups: [ "" ] - resources: [ endpoints,endpointslices ] + resources: [ endpoints ] + verbs: [ get,list,watch ] +- apiGroups: [ "discovery.k8s.io" ] + resources: [ endpointslices ] Review Comment: @ChuanFF Based on the documentation, this feature only reached stable status in Kubernetes `v1.21`. Did the original documentation work correctly in older versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
