ronething commented on code in PR #2489:
URL:
https://github.com/apache/apisix-ingress-controller/pull/2489#discussion_r2227215220
##########
internal/controller/apisixconsumer_controller.go:
##########
@@ -51,11 +52,13 @@ type ApisixConsumerReconciler struct {
Provider provider.Provider
Updater status.Updater
+ Readier readiness.ReadinessManager
}
// Reconcile FIXME: implement the reconcile logic (For now, it dose nothing
other than directly accepting)
func (r *ApisixConsumerReconciler) Reconcile(ctx context.Context, req
ctrl.Request) (ctrl.Result, error) {
r.Log.Info("reconcile", "request", req.NamespacedName)
+ r.Readier.Done(&apiv2.ApisixConsumer{}, req.NamespacedName)
Review Comment:
It would be more reasonable to execute the packaging within `defer func`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
