deiwin commented on code in PR #11943:
URL: https://github.com/apache/apisix/pull/11943#discussion_r2154746612


##########
apisix/plugins/datadog.lua:
##########
@@ -80,10 +89,24 @@ local function generate_tag(entry, const_tags)
         tags = {}
     end
 
+    if entry.constant_tags and #entry.constant_tags > 0 then
+        for _, tag in pairs(entry.constant_tags) do
+            core.table.insert(tags, tag)

Review Comment:
   Added here: 
https://github.com/apache/apisix/pull/11943/commits/b761540f61f26c5072cb6513adbbffbe5c99514b
   
   Although to be clear, these new tags previously followed the current 
approach with `constant_tags` provided via plugin configuration, which were 
also included as-is, without validation. Both are validated now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to