LiteSun commented on code in PR #12083:
URL: https://github.com/apache/apisix/pull/12083#discussion_r2015547788
##########
apisix/plugins/ai-request-rewrite.lua:
##########
@@ -124,13 +124,12 @@ local function request_to_llm(conf, request_table, ctx)
model_options = conf.options
}
- local res, err, httpc = ai_driver:request(conf, request_table, extra_opts)
Review Comment:
>
https://github.com/apache/apisix/blob/master/apisix/plugins/ai-drivers/openai-base.lua#L131
>
> It seems that only two parameters were returned, why didn't painc occur
before?
This issue occurred because when I started development and created my
branch, the function was returning three parameters. After this PR was merged:
https://github.com/apache/apisix/pull/12030/files#diff-b9bb0990d3ea842c42b094837737acfb597e2c8bf3a976dda8be56c84ef5b3c0L109,
the returned parameters were adjusted. The code in my branch hasn't been
synchronized with upstream, which caused this inconsistency.
> I think at least one pass case is needed, and there should be no error
level logs.
The test cases are already covered, and the tests cannot pass without making
this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
