This is an automated email from the ASF dual-hosted git repository.
jaikiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant-ivy.git
The following commit(s) were added to refs/heads/master by this push:
new 083e3f6 IVY-1628 Fix potential ConcurrentModificationException
083e3f6 is described below
commit 083e3f685c1fe29092e59c63b87e81d31fc9babe
Author: Jaikiran Pai <[email protected]>
AuthorDate: Tue Mar 23 07:30:02 2021 +0530
IVY-1628 Fix potential ConcurrentModificationException
---
.../org/apache/ivy/util/MessageLoggerHelper.java | 43 +++++++++++-----------
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/src/java/org/apache/ivy/util/MessageLoggerHelper.java
b/src/java/org/apache/ivy/util/MessageLoggerHelper.java
index 600a18d..1ff64b1 100644
--- a/src/java/org/apache/ivy/util/MessageLoggerHelper.java
+++ b/src/java/org/apache/ivy/util/MessageLoggerHelper.java
@@ -17,34 +17,35 @@
*/
package org.apache.ivy.util;
+import java.util.ArrayList;
import java.util.List;
public final class MessageLoggerHelper {
public static void sumupProblems(MessageLogger logger) {
- List<String> myProblems = logger.getProblems();
- if (myProblems.size() > 0) {
- List<String> myWarns = logger.getWarns();
- List<String> myErrors = logger.getErrors();
- logger.info(""); // new line on info to isolate error summary
- if (!myErrors.isEmpty()) {
- logger.log(":: problems summary ::", Message.MSG_ERR);
- } else {
- logger.log(":: problems summary ::", Message.MSG_WARN);
- }
- if (myWarns.size() > 0) {
- logger.log(":::: WARNINGS", Message.MSG_WARN);
- for (String msg : myWarns) {
- logger.log("\t" + msg + "\n", Message.MSG_WARN);
- }
+ if (logger.getProblems().isEmpty()) {
+ return;
+ }
+ final List<String> warns = new ArrayList<>(logger.getWarns());
+ final List<String> errors = new ArrayList<>(logger.getErrors());
+ logger.info(""); // new line on info to isolate error summary
+ if (!errors.isEmpty()) {
+ logger.log(":: problems summary ::", Message.MSG_ERR);
+ } else {
+ logger.log(":: problems summary ::", Message.MSG_WARN);
+ }
+ if (warns.size() > 0) {
+ logger.log(":::: WARNINGS", Message.MSG_WARN);
+ for (String msg : warns) {
+ logger.log("\t" + msg + "\n", Message.MSG_WARN);
}
- if (myErrors.size() > 0) {
- logger.log(":::: ERRORS", Message.MSG_ERR);
- for (String msg : myErrors) {
- logger.log("\t" + msg + "\n", Message.MSG_ERR);
- }
+ }
+ if (errors.size() > 0) {
+ logger.log(":::: ERRORS", Message.MSG_ERR);
+ for (String msg : errors) {
+ logger.log("\t" + msg + "\n", Message.MSG_ERR);
}
- logger.info("\n:: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE
DETAILS");
}
+ logger.info("\n:: USE VERBOSE OR DEBUG MESSAGE LEVEL FOR MORE
DETAILS");
}
private MessageLoggerHelper() {
