keith-turner commented on PR #5443: URL: https://github.com/apache/accumulo/pull/5443#issuecomment-2772796359
> Should modifying tables create write locks on the namespace? It seems like they should, since creating a table is modifying the namespace contents (just like you need write access on a directory to create a file in the directory in Linux). With the https://github.com/apache/accumulo/issues/4698, it seems like this check will be easier. We could just read the mapping directly from ZooKeeper. Since operations get table write locks they are operating on different tables in the namespace. This avoids all problems I can think of. If ops like create table did get a namespace write lock, then would not be able to run concurrent create table ops in the same namespace. > The string-based check makes me uncomfortable. It seems too fragile. Guess that string is kinda sketchy. The motivation for that design was to minimize code change by leveraging as much existing code as possible w/o changing it since its a bug fix change for an obscure edge case. Maybe took that a bit too far. Will look at improving it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
