ctubbsii commented on code in PR #5282:
URL: https://github.com/apache/accumulo/pull/5282#discussion_r2004457198
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java:
##########
@@ -340,7 +340,7 @@ private void
logBusyTablets(List<ComparablePair<Long,KeyExtent>> busyTablets,
this.security = context.getSecurityOperation();
watchCriticalScheduledTask(context.getScheduledExecutor().scheduleWithFixedDelay(
- TabletLocator::clearLocators, jitter(), jitter(),
TimeUnit.MILLISECONDS));
+ () -> TabletLocator.clearLocators(context), jitter(), jitter(),
TimeUnit.MILLISECONDS));
Review Comment:
It seems to me that this is probably still needed. There is nothing else
clearing up the locators for any particular TableId, except as an optional
behavior of the BatchWriterIterator, that doesn't seem to be documented or
tested at all, and has no comments as to its purpose. It doesn't seem to be
used by our code at all.
So, this is really the only place where any of the locators would be cleaned
up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
