dlmarion commented on code in PR #5321:
URL: https://github.com/apache/accumulo/pull/5321#discussion_r1962309680
##########
assemble/bin/accumulo-cluster:
##########
@@ -471,6 +477,13 @@ function control_services() {
fi
fi
done
+ if [[ $operation == "stop" || $operation == "kill" ]]; then
+ # If the prior commands were executed via ssh, then we need to wait
for them
+ # to complete before zapping the nodes in ZooKeeper
+ ssh_wait
+ echo "Cleaning tablet server entries from zookeeper for resource group
$group"
+ debugOrRun "$accumulo_cmd" org.apache.accumulo.server.util.ZooZap
-verbose -tservers -group "$group"
Review Comment:
Really good catch! I think your suggestion of `could be fixed by adding
logic to check for the --local arg and only removing entries if its a
cluster-wide action` should be sufficient. The issue I'm trying to solve here,
re-adding functionality introduced in #5114 and subsequently removed in the
Great Script Refactor, did not address the local case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
