dlmarion commented on code in PR #5334:
URL: https://github.com/apache/accumulo/pull/5334#discussion_r1956631773
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/clone/FinishCloneTable.java:
##########
@@ -50,26 +50,23 @@ public Repo<Manager> call(long tid, Manager environment) {
// that are not used... tablet will create directories as needed
final EnumSet<TableState> expectedCurrStates = EnumSet.of(TableState.NEW);
- if (cloneInfo.keepOffline) {
- environment.getTableManager().transitionTableState(cloneInfo.tableId,
TableState.OFFLINE,
+ if (cloneInfo.isKeepOffline()) {
+
environment.getTableManager().transitionTableState(cloneInfo.getTableId(),
TableState.OFFLINE,
expectedCurrStates);
} else {
- environment.getTableManager().transitionTableState(cloneInfo.tableId,
TableState.ONLINE,
+
environment.getTableManager().transitionTableState(cloneInfo.getTableId(),
TableState.ONLINE,
expectedCurrStates);
}
+ Utils.unreserveNamespace(environment, cloneInfo.getNamespaceId(), tid,
false);
+ Utils.unreserveTable(environment, cloneInfo.getSrcTableId(), tid, false);
+ Utils.unreserveTable(environment, cloneInfo.getTableId(), tid, true);
Review Comment:
Move the table write lock release to the front in 3cfb06c.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
