cshannon commented on code in PR #5335:
URL: https://github.com/apache/accumulo/pull/5335#discussion_r1956394406
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/TabletMetadata.java:
##########
@@ -202,7 +206,74 @@ public enum ColumnType {
COMPACTED,
USER_COMPACTION_REQUESTED,
UNSPLITTABLE,
- MERGEABILITY
+ MERGEABILITY;
+
+ public static Set<ByteSequence> resolveFamilies(Set<ColumnType> columns) {
Review Comment:
The methods are a bit different so we may need to do something like have
some immutable maps that map between ColumnType and ColumnFQ or families.
`TabletsMetadata.Builder.fetch` is adding families for some columns and column
qualifiers for others where the other method is only resolving families.
I also noticed that the fetch() method is missing `FLUSH_NONCE` from the
ColumnType enum, which I suppose means it isn't being used by the fetch()
method anywhere but it probably should be added. Maybe we need a test that will
iterate over all the values in the enum to verify it's handled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
