kevinrr888 commented on PR #5331:
URL: https://github.com/apache/accumulo/pull/5331#issuecomment-2657445667

   Here is where the referenced thread pool is created:
   
https://github.com/apache/accumulo/blob/d5e5c5880bbd06fcd2d5bbe525885e4dbc65106c/core/src/main/java/org/apache/accumulo/core/fate/Fate.java#L424-L425
   note that `true` is set for `emitThreadPoolMetrics`
   This ultimately results in calling:
   
https://github.com/apache/accumulo/blob/d5e5c5880bbd06fcd2d5bbe525885e4dbc65106c/core/src/main/java/org/apache/accumulo/core/util/threads/ThreadPools.java#L720-L722
   
   I think the solution is to just pass false instead for the first part of the 
issue.
   
   For the more suitable replacement Keith suggested:
   The Manager is what runs FATE and creates FATE metrics here:
   
https://github.com/apache/accumulo/blob/d5e5c5880bbd06fcd2d5bbe525885e4dbc65106c/server/manager/src/main/java/org/apache/accumulo/manager/Manager.java#L1167
   I believe what Keith is suggesting is adding a new guage to the FATE metrics 
for all `FateMetrics` (this includes both `UserFateMetrics` and 
`MetaFateMetrics`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to