DomGarguilo commented on issue #5245:
URL: https://github.com/apache/accumulo/issues/5245#issuecomment-2611006740

   > If propagating that Exception will be enough to not keep subsequent calls 
from using the RFile, then I think the Accumulo code is OK.. but I have not 
verified this.
   
   I haven't done a whole lot of digging yet but it seems like the Accumulo 
code might be okay. 
   
   The only thing I can think of that might improve things on the accumulo side 
would be to maybe fail earlier. So maybe creating another flag that becomes 
`true` when `reset()` is called in the `LocalityGroupReader` so that when 
`next()` or `seek()` is called, we can check this flag and immediately throw an 
Exception. I don't think this would fix the problem you were seeing but might 
make things more evident in the calling code. 
   
   I am not very familiar with this code. Just wanted to leave my initial 
thoughts when looking into things.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to