ctubbsii commented on code in PR #5253:
URL: https://github.com/apache/accumulo/pull/5253#discussion_r1915289392
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java:
##########
@@ -247,7 +247,8 @@ public ClientContext(SingletonReservation reservation,
ClientInfo info,
this.singletonReservation = Objects.requireNonNull(reservation);
this.tableops = new TableOperationsImpl(this);
this.namespaceops = new NamespaceOperationsImpl(this, tableops);
- this.serverPaths = Suppliers.memoize(() -> new ServiceLockPaths(this));
+ this.serverPaths =
+ Suppliers.memoize(() -> new ServiceLockPaths(this.getZooKeeperRoot(),
this.getZooCache()));
Review Comment:
No, I don't think so. It never has been, anyway. The ZK that is backing it
is closed, though, and ZooCache should stop receiving requests from the client.
ZooCache isn't an AutoCloseable, though, and its close method isn't very
meaningful (it just sets a boolean that prevents it from working, but doesn't
actually clean up any resources). I haven't seen many occurrences where it is
bothered to be closed, and I haven't added any.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
