ctubbsii commented on code in PR #5246:
URL: https://github.com/apache/accumulo/pull/5246#discussion_r1912345525
##########
server/base/src/main/java/org/apache/accumulo/server/util/ZooZap.java:
##########
@@ -90,6 +90,19 @@ public static void main(String[] args) throws Exception {
@Override
public void execute(String[] args) throws Exception {
+ try {
+ var siteConf = SiteConfiguration.auto();
+ // Login as the server on secure HDFS
+ if (siteConf.getBoolean(Property.INSTANCE_RPC_SASL_ENABLED)) {
+ SecurityUtil.serverLogin(siteConf);
+ }
+ zap(siteConf, args);
Review Comment:
Looking at the diff ignoring whitespace changes makes this easier to see. It
looks like the only thing that changed was that the jcommander option parsing
got moved into the try block. Otherwise, I don't think there's any substantive
change in this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
