cshannon commented on code in PR #5243:
URL: https://github.com/apache/accumulo/pull/5243#discussion_r1910933070


##########
core/src/main/java/org/apache/accumulo/core/fate/Fate.java:
##########
@@ -476,10 +477,18 @@ public Fate(T environment, FateStore<T> store, boolean 
runDeadResCleaner,
     this.workFinder.start();
   }
 
+  public Duration getInitialDelay() {

Review Comment:
   Is the plan to allow overriding these methods? If not maybe they could be 
public and statically defined constants in Fate? Even if we want to keep the 
methods to allow overriding they could delegate to the statically defined 
constants (if you keep the methods they could be private). This way we are not 
creating new objects each time the method is called.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to