keith-turner commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-2439695783
Experimented with adding tableId tags to metric in this [branch](https://github.com/keith-turner/accumulo/tree/accumulo-4511). The branch is a mess because I got sidetracked by https://github.com/micrometer-metrics/micrometer/issues/5607 during this experiment which caused the following problem. 1. Tsever creates a registry that ingnores tableId tags using the SPI plugin and then wraps this registry with a CompositeMeterRegistry 2. Tsever hosts a tablet for tableId=1 and create meters for tableId=1 3. Tsever hosts a tablet for tableId=2 and create meters for tableId=2 4. The tablet for tableId=1 is unloaded from the tserver and there are no other tablets for tableId=1 so remove the meters for tableId=1. Because of micrometer issue 5607 after this removal no metrics are ever seen again for tableId=2. Trying to figure out how this could be worked around and/or fixed upstream. Want to wait and see if the bug is considered valid before attempting an upstream fix. If we can not figure out a workaround, this bug may prevent adding tableId tags to metrics because we must have the ability to filter out tableId tags. Would only run into this bug if filtering and/or collapsing the tableId tag using a MeterFilter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
